-
Notifications
You must be signed in to change notification settings - Fork 332
Release of Scala 2.11.0 final. #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review by @sjrd @heathermiller The release notes themselves will be updated as open source libraries publish. But I want to start the review process now to make sure we are comprehensive with updates to the site needed for a new major version. |
documentation/api.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this come before 2.10.4 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
|
ZOMG – 2.11 final. So wow. |
|
In announcement (which I cannot display in diff mode, for some reason, and hence am not able to comment in-line):
Must definitely go away. |
|
I'm currently home on my Windows and I don't have the tools to generate here. (I could generate via ssh but could not see the visual result ...) |
|
I get that breakage locally, too. I'll play around with it to isolate the problem. @sjrd I've removed the RC reference. |
|
@sjrd Not sure if you have time to try it, but I use jekyll on cygwin, and these instructions worked for me: http://matt.scharley.me/2012/03/10/windows-cygwin-and-jekyll.html |
Since sbt 0.13.2 final is out, this text should be updated. |
|
That's all for me. |
|
@retronym I haven't messed around with it yet, but the last time I got breakage that looked like this, there was an HTML comment in the immediately preceding news item that caused it. (The "previous news items" thing is achieved by using chunks of HTML generated by Jekyll). Might be worth starting there? |
... and mention two recently published libraries for 2.11 Removing comment in 2014-04-08-release-notes-2.11.0-RC4.md was the minimal change needed to fix the layout bug on the homepage. I have updated our generator to strip out internal comments before shipping the markdown your way: scala/make-release-notes#86
|
@heathermiller Yep that was it. I think I've fixed that for good now, see comments in the latest commit. |
|
Awesome, good going on scala/make-release-notes#86. Would've eaten time and cycles again in the future if So everything generates well, it looks good. The last nitpick is that I'm getting an error upon generating but which doesn't actually seem to mean anything (as far as I can tell) I'm not sure how Jekyll thinks line 14, column 1 is a |
|
@heathermiller I don't see that error with jekyll 1.4.3. |
Release of Scala 2.11.0 final.

For review now, merge on Monday.