Skip to content

Conversation

@retronym
Copy link
Member

For review now, merge on Monday.

@retronym
Copy link
Member Author

Review by @sjrd @heathermiller

The release notes themselves will be updated as open source libraries publish. But I want to start the review process now to make sure we are comprehensive with updates to the site needed for a new major version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this come before 2.10.4 now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@heathermiller
Copy link
Member

ZOMG – 2.11 final. So wow.

@heathermiller
Copy link
Member

Hmm, it seems the front page layout is a bit broken for me when I try to generate:

@sjrd
Copy link
Member

sjrd commented Apr 17, 2014

In announcement (which I cannot display in diff mode, for some reason, and hence am not able to comment in-line):

Please do try out this release candidate to help us find any serious regressions before the final release. The next release candidate (or the final) will be cut on Friday April 11, if there are no unresolved blocker bugs. Our goal is to have the next release be the final -- please help us make sure there are no important regressions!

Must definitely go away.

@heathermiller
Copy link
Member

@retronym and @sjrd could you guys confirm/deny whether the above breakage occurs for you when you generate locally?

@sjrd
Copy link
Member

sjrd commented Apr 17, 2014

I'm currently home on my Windows and I don't have the tools to generate here. (I could generate via ssh but could not see the visual result ...)

@retronym
Copy link
Member Author

I get that breakage locally, too. I'll play around with it to isolate the problem.

@sjrd I've removed the RC reference.

@axel22
Copy link
Contributor

axel22 commented Apr 17, 2014

@sjrd Not sure if you have time to try it, but I use jekyll on cygwin, and these instructions worked for me: http://matt.scharley.me/2012/03/10/windows-cygwin-and-jekyll.html

@sjrd
Copy link
Member

sjrd commented Apr 17, 2014

Incremental compilation has been improved significantly. To try it out, upgrade to sbt 0.13.2-M2 and [...]

Since sbt 0.13.2 final is out, this text should be updated.

@sjrd
Copy link
Member

sjrd commented Apr 17, 2014

That's all for me.

@heathermiller
Copy link
Member

@retronym I haven't messed around with it yet, but the last time I got breakage that looked like this, there was an HTML comment in the immediately preceding news item that caused it. (The "previous news items" thing is achieved by using chunks of HTML generated by Jekyll). Might be worth starting there?

... and mention two recently published libraries for 2.11

Removing comment in 2014-04-08-release-notes-2.11.0-RC4.md was the
minimal change needed to fix the layout bug on the homepage.

I have updated our generator to strip out internal comments
before shipping the markdown your way:

  scala/make-release-notes#86
@retronym
Copy link
Member Author

@heathermiller Yep that was it. I think I've fixed that for good now, see comments in the latest commit.

@heathermiller
Copy link
Member

Awesome, good going on scala/make-release-notes#86. Would've eaten time and cycles again in the future if

So everything generates well, it looks good.

The last nitpick is that I'm getting an error upon generating but which doesn't actually seem to mean anything (as far as I can tell)

Generating... Error reading file /Users/hmiller/Dropbox/git-shared/scala-lang/download/index.md: syntax error on line 14, col 1: `]'

I'm not sure how Jekyll thinks line 14, column 1 is a ]. Not sure if this is just my version of Jekyll (1.1.2) or if this is some actual error?

@retronym
Copy link
Member Author

@heathermiller I don't see that error with jekyll 1.4.3.

retronym added a commit that referenced this pull request Apr 21, 2014
Release of Scala 2.11.0 final.
@retronym retronym merged commit 10f8013 into scala:master Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants